Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Equinox.Cosmos over to System.Text.Json #200

Merged
merged 19 commits into from
Mar 3, 2020
Merged

Switch Equinox.Cosmos over to System.Text.Json #200

merged 19 commits into from
Mar 3, 2020

Conversation

ylibrach
Copy link

This PR accomplishes two main goals:

  • Equinox.Cosmos is now free of Newtonsoft.Json and switched over to System.Text.Json
  • Data and metadata fields in events are changed from byte[] to JsonElement

Copy link
Collaborator

@bartelink bartelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of minor suggestions

src/Equinox.Cosmos/CosmosJsonSerializer.fs Show resolved Hide resolved
src/Equinox.Cosmos/Equinox.Cosmos.fsproj Outdated Show resolved Hide resolved
src/Equinox.Cosmos/Json/JsonElementHelpers.fs Outdated Show resolved Hide resolved
src/Equinox.Cosmos/Json/JsonElementHelpers.fs Outdated Show resolved Hide resolved
src/Equinox.Cosmos/Json/JsonRecordConverter.fs Outdated Show resolved Hide resolved
src/Equinox.Cosmos/Json/Utf8JsonReaderExtensions.fs Outdated Show resolved Hide resolved
tests/Equinox.Cosmos.Integration/CosmosIntegration.fs Outdated Show resolved Hide resolved
src/Equinox.Cosmos/Cosmos.fs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants