MemoryStore: Fix Version for post-context in Equinox.Decider.TransactEx #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
commented
Nov 2, 2021
| /// Represent a known array of events (without a known folded State) | ||
| let ofEventArray streamName fold initial (events: 'event array) = tokenOfArray streamName events, fold initial (Seq.ofArray events) | ||
| /// Represent a known array of Events together with the associated state | ||
| let ofEventArrayAndKnownState streamName fold (state: 'state) (events: 'event seq) = tokenOfSeq streamName events, fold state events |
There was a problem hiding this comment.
note this computes an incorrect token as the event count is derived from the new events, not the post-state value of the events for this stream
There was a problem hiding this comment.
also an example of how confusing egregious use of |> is never a good thing (I try very hard not to do that as I'm conscious of it, but I evidently thought I was being very clever)
|
Spotted during code review as I wondered whether SELECT was broken (it wasn't - the fundamentals of MemoryStore have good coverage, and the system I'm currently writing makes significant use of every nook and cranny...) Aside: actual PEBKAC that made me find it ^ does not do what I mean |
bartelink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects
MemoryStore's computation of the post-Versionfor use byEquinox.Decider.TransactExRefactors conflict case path to remove ugly use of
Exceptionthat I once assumed to be unavoidable