Replace Context API with Transact and Accumulator #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out with great patience by @eiriktsarpalis in internal reviews, the
ContextAPI (which was arrived at by me in migrating diverse implementations to a common API style) was not a good default programming model (as evidenced by "if you're explaining, you're losing" in #86) for many reasons including at least:ExecutevsDecide) and abstractions that don't generalizeThis is replaced with a more direct surface level API:
Handler.Transact(interpret: 'state -> 'result * 'event list) : Async<'result>Even though this arguably makes some handlers less legible, the benefit is that the above API takes far less explaining, and does not rule out any scenarios.
The
Accumulatortype remains for porting purposes, but is not important to understand and may be deprecated in the future depending on other feedback.