[shellenv] add --recompute flag with default=true, while keep global shellenv's recompute flag with default=false

[savil]

Summary

Credit to @dax and #1963 for pointing out the need for this, and pioneering this solution.
This PR merely nudges the code to be a bit neater.

How was it tested?

% git diff
diff --git a/internal/boxcli/shellenv.go b/internal/boxcli/shellenv.go
index 991c2bec..8076e125 100644
--- a/internal/boxcli/shellenv.go
+++ b/internal/boxcli/shellenv.go
@@ -78,6 +78,9 @@ func shellEnvFunc(
        cmd *cobra.Command,
        flags shellEnvCmdFlags,
 ) (string, error) {
+       fmt.Printf("shellenv --recompute flag is %v\n", flags.recompute)
+       return "", nil
+
        env, err := flags.Env(flags.config.path)
        if err != nil {
                return "", err

compiled via devbox run build, and then:

 % devbox shellenv
shellenv --recompute flag is true

hash -r
 % devbox global shellenv
shellenv --recompute flag is false

hash -r

[savil]

• [shellenv] add --recompute flag with default=true, while keep global shellenv's recompute flag with default=false #2013 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @savil and the rest of your teammates on Graphite

[savil]

@mikeland73 @gcurtis ping

[mikeland73]

I don't think this is strictly needed , only for internal consistency. maybe add a comment?

[savil]

The DefValue modifies the default value printed in the --help. Without this line, the help for the flag looks like:

% devbox global shellenv --help
...
  -r, --recompute            Recompute environment if needed (default true)

[savil]

Added comment to explain this need.

[mikeland73]

Maybe add comment:

// This will never panic because internally it just does `strconv.ParseBool("false")` which is always valid

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ *Generic Error: write flake_remove_nixpkgs.nix to file: <redacted fs.PathError>: go.jetpack.io/devbox/internal/shellgen in write... View Issue
• ‼️ **Generic Error: <redacted errors.withStack>: <redacted usererr.combined> go.jetpack.io/devbox/internal/boxcli/usererr in... View Issue

_{Did you find this useful? React with a 👍 or 👎}