[easy][lock-tidy] Don't tidy flakes #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jun 19, 2024
| @@ -145,6 +145,7 @@ func newPackage(raw string, isInstallable func() bool, locker lock.Locker) *Pack | |||
| // assume a Devbox package. | |||
| parsed, err := flake.ParseInstallable(raw) | |||
| if err != nil || pkgtype.IsAmbiguous(raw, parsed) { | |||
| // TODO: This sets runx packages as devbox packages. Not sure if that's what we want. | |||
There was a problem hiding this comment.
oooh :D
good thing runx isn't public yet, so we can land this
There was a problem hiding this comment.
This hasn't broken anything for us (yet) even though we use runx. But I think in the future this confusion could lead to bugs.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?