Skip to content

Commit

Permalink
Fix: bugs of deps
Browse files Browse the repository at this point in the history
- Yarn 1 has a bug with "string-width"
(Ref. storybookjs/storybook#22431 (comment))
- MSW has a bug with logging system
(Ref. mswjs/msw#1640 (comment))
  • Loading branch information
jetsbee committed Jul 20, 2023
1 parent 35d0f93 commit af31507
Show file tree
Hide file tree
Showing 4 changed files with 383 additions and 537 deletions.
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@
"@tanstack/eslint-plugin-query": "^4.29.9",
"@types/html-to-text": "^9.0.1",
"eslint-plugin-storybook": "^0.6.12",
"msw": "^1.2.2",
"msw": "^1.2.3",
"msw-storybook-addon": "^1.8.0",
"storybook": "^7.1.0"
},
"//": "ref. https://github.com/storybookjs/storybook/issues/22431#issuecomment-1630086092",
"resolutions": {
"jackspeak": "2.1.1"
},
"msw": {
"workerDirectory": "public"
}
}
}
2 changes: 1 addition & 1 deletion public/mockServiceWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/* tslint:disable */

/**
* Mock Service Worker (1.2.2).
* Mock Service Worker (1.2.3).
* @see https://github.com/mswjs/msw
* - Please do NOT modify this file.
* - Please do NOT serve this file on production.
Expand Down
2 changes: 0 additions & 2 deletions src/app/bookmarks/page.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ const meta: Meta<typeof BookmarksPage> = {
export default meta;
type Story = StoryObj<typeof BookmarksPage>;

// There's error on browser console. (Something with BookmarksStoreProvider and MSW)
// ref. https://github.com/mswjs/msw/issues/1640#issuecomment-1642283698
export const Default: Story = {
decorators: [
...RootPageMeta.decorators!,
Expand Down
Loading

0 comments on commit af31507

Please sign in to comment.