This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Return ingress.class value for ingress.provider if not set #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munnerz
commented
Jul 5, 2017
| } | ||
|
|
||
| kl.legoSupportedIngressClass = strings.Split(os.Getenv("LEGO_SUPPORTED_INGRESS_CLASS"), ",") | ||
| if len(kl.legoSupportedIngressClass) == 0 { |
There was a problem hiding this comment.
The issue here is that len(strings.Split("", ",")) == 1, and not 0, meaning the default would never be set.
|
This is a follow-up to the recently merged #202 - @simonswine could you take a look over. /cc @jackhopner |
|
Any reason to remove the option to set the default @munnerz ? We could have it check if the default was set otherwise return the ingress class? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve a regression that causes the GCE ingress controller implementation to not work with manifests that don't explicitly set
kubernetes.io/ingress.provider: gce. Without this change, these manifests would attempt to use thenginxprovider.This also solves a problem where the default supported ingress classes were not set correctly if not specified.