This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Reintroduce default ingress provider #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation should be backwards compatible as it will default the provider to the same value as the class
Multiply
reviewed
Oct 26, 2017
README.md
Outdated
| @@ -113,6 +113,7 @@ Please note: | |||
| | `LEGO_CHECK_INTERVAL` | n | `8h` | Interval for periodically certificate checks (to find expired certs)| | |||
| | `LEGO_MINIMUM_VALIDITY` | n | `720h` (30 days) | Request a renewal when the remaining certificate validity falls below that value| | |||
| | `LEGO_DEFAULT_INGRESS_CLASS` | n | `nginx` | Default ingress class for resources without specification| | |||
| | `LEGO_DEFAULT_INGRESS_PROVIDER` | n | `$LEGO_DEFAULT_INGRESS_CLASS` | Default ingress provider for resources without specification| | |||
There was a problem hiding this comment.
Could use a space before the last |. I know some of the lines above doesn't follow it, but the rest of the table seems to do so.
|
This LGTM. I think I removed code similar (although minus the defaulting to class) a while back. Thanks for working to get the default provider back in there without the backwards incompatibility! |
|
& thanks very much for the contribution too..! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation should be backwards compatible as
it will default the provider to the same value as the class.
Relates to #233