Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Make e2e tests fail when controller logs contain unexpected errors #100

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Nov 3, 2017

Filter the logs for errors that are not expected.
e.g. Errors caused by the controller attempting to list navigator API resources before the navigator API has been registered.

Release note:

NONE

@wallrj
Copy link
Member Author

wallrj commented Nov 3, 2017

In #96 (comment) @munnerz wrote:

As much as this does make it easier to read logs, I think it could also obscure information and make debugging tests harder, especially if the developer isn't aware that we filter logs out.

I still print the entire logs if the tests fail.
This new test is intended to alert us to unexpected errors in the log files, such as those that were caused by the missing event: patch verb in #95

@munnerz
Copy link
Contributor

munnerz commented Nov 7, 2017

/lgtm
/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Collaborator

Automatic merge from submit-queue.

@jetstack-bot jetstack-bot merged commit bd28ba6 into jetstack:master Nov 7, 2017
@wallrj wallrj deleted the fail-e2e-on-logged-errors branch November 8, 2017 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants