This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Retry the kube-system RBAC cluserrolebinding fix #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent intermittent E2E test failures in case Minikube API server is not yet ready to accept configuration changes. Inspired by: kubernetes/minikube#1904
munnerz
force-pushed
the
117-retry-kube-system-binding
branch
from
12abe93
to
111982a
Compare
|
/test e2e |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test all |
|
/test e2e 1.8 |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test all |
|
Automatic merge from submit-queue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent intermittent E2E test failures in case Minikube API server is
not yet ready to accept configuration changes.
Inspired by: kubernetes/minikube#1904
Fixes: #117
Release note: