Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Feed the stdout and stderr of the Pilot subprocess into glog #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Dec 1, 2017

Fixes: #166
Release note:

NONE

@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: wallrj

Assign the PR to them by writing /assign @wallrj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wallrj
Copy link
Member Author

wallrj commented Dec 1, 2017

/test e2e

@wallrj
Copy link
Member Author

wallrj commented Dec 1, 2017

/test e2e

@wallrj wallrj force-pushed the 166-pilot-subprocess-logs branch 2 times, most recently from 01af37b to 85dfd2b Compare December 1, 2017 18:35
@wallrj
Copy link
Member Author

wallrj commented Dec 1, 2017

/test e2e

@wallrj
Copy link
Member Author

wallrj commented Dec 2, 2017

/test e2e

@wallrj
Copy link
Member Author

wallrj commented Dec 5, 2017

/test e2e

@wallrj wallrj force-pushed the 166-pilot-subprocess-logs branch 2 times, most recently from cc83e38 to 45bf286 Compare December 13, 2017 15:32
@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wallrj
Copy link
Member Author

wallrj commented Jan 24, 2018

e.g.

I0124 14:42:32.136] I0124 14:40:41.104741       1 process.go:63] changed ownership of '/cassandra_data/data' from root to cassandra
I0124 14:42:32.136] I0124 14:40:41.104942       1 process.go:63] changed ownership of '/cassandra_data' from root to cassandra
I0124 14:42:32.136] I0124 14:40:41.104991       1 process.go:63] changed ownership of '/etc/cassandra/cassandra-env.sh' from root to cassandra
I0124 14:42:32.136] I0124 14:40:41.104999       1 process.go:63] changed ownership of '/etc/cassandra/cassandra.yaml' from root to cassandra
I0124 14:42:32.137] I0124 14:40:41.105004       1 process.go:63] changed ownership of '/etc/cassandra/jvm.options' from root to cassandra
I0124 14:42:32.137] I0124 14:40:41.105009       1 process.go:63] changed ownership of '/etc/cassandra/logback.xml' from root to cassandra
I0124 14:42:32.137] I0124 14:40:41.105015       1 process.go:63] changed ownership of '/etc/cassandra/cassandra-rackdc.properties' from root to cassandra
I0124 14:42:32.137] I0124 14:40:41.105109       1 process.go:63] changed ownership of '/etc/cassandra' from root to cassandra
I0124 14:42:32.137] E0124 14:40:42.623414       1 process.go:80] OpenJDK 64-Bit Server VM warning: Cannot open file /usr/local/apache-cassandra-3.9/logs/gc.log due to No such file or directory
I0124 14:42:32.137] E0124 14:40:42.623528       1 process.go:80] 

https://jetstack-build-infra.appspot.com/build/jetstack-logs/pr-logs/pull/jetstack_navigator/167/navigator-e2e-v1-9/144/?log#log

@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@munnerz
Copy link
Contributor

munnerz commented Jun 5, 2018

Digging this old PR back up...

We've discussed making it easier to distinguish app logs from Pilot itself - I definitely think we should do that, however I am not sure if pushing those logs into glog like this helps that goal.

@cehoffman what are your thoughts?
We could send Pilot logs to a file instead, or alternatively give all non-DB logs some form of prefix.

In 'optimal' operating conditions, Pilot should be pretty silent. I think right now Navigator sets the --v level to something like 6 on each Pilot, which causes them to be very chatty. We can reduce that and hopefully that'll help short term?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants