-
Notifications
You must be signed in to change notification settings - Fork 31
Remove cassandra chart #258
Remove cassandra chart #258
Conversation
4dd1fe4
to
7de21ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kragniz
Looks good me, but:
- add a couple of notes to the PR description explaining the motivation for this change (summary of our conversation yesterday)
- I think maybe give @mattbates a heads up incase he's planning on using the helm chart in demos.
- Create a followup issue for your idea of syncing the testdata manifests with those in the docs.
- Make the cluster name a parameter too (looks like that was what you intended anyway.)
apiVersion: "navigator.jetstack.io/v1alpha1" | ||
kind: "CassandraCluster" | ||
metadata: | ||
name: "test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a CASS_NAME parameter I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
2042c36
to
7effb87
Compare
cb6dc6f
to
a87d125
Compare
a87d125
to
3989209
Compare
Now rebased on master with tests passing again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
We should encourage users to directly use the CassandraCluster and ElasticsearchCluster resources. The helm chart creates a layer of abstraction I don't think we need, and there is no corresponding elasticsearch chart.
This instead uses the same templating elasticsearch uses for e2e testing (envsubst).
/cc @mattbates