This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Remove cassandra chart #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kragniz
force-pushed
the
remove-cassandra-chart
branch
8 times, most recently
from
4dd1fe4
to
7de21ef
Compare
wallrj
approved these changes
Feb 27, 2018
There was a problem hiding this comment.
Thanks @kragniz
Looks good me, but:
- add a couple of notes to the PR description explaining the motivation for this change (summary of our conversation yesterday)
- I think maybe give @mattbates a heads up incase he's planning on using the helm chart in demos.
- Create a followup issue for your idea of syncing the testdata manifests with those in the docs.
- Make the cluster name a parameter too (looks like that was what you intended anyway.)
| apiVersion: "navigator.jetstack.io/v1alpha1" | ||
| kind: "CassandraCluster" | ||
| metadata: | ||
| name: "test" |
There was a problem hiding this comment.
This should be a CASS_NAME parameter I think
kragniz
force-pushed
the
remove-cassandra-chart
branch
from
2042c36
to
7effb87
Compare
kragniz
force-pushed
the
remove-cassandra-chart
branch
2 times, most recently
from
cb6dc6f
to
a87d125
Compare
kragniz
force-pushed
the
remove-cassandra-chart
branch
from
a87d125
to
3989209
Compare
|
Now rebased on master with tests passing again |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should encourage users to directly use the CassandraCluster and ElasticsearchCluster resources. The helm chart creates a layer of abstraction I don't think we need, and there is no corresponding elasticsearch chart.
This instead uses the same templating elasticsearch uses for e2e testing (envsubst).
/cc @mattbates