-
Notifications
You must be signed in to change notification settings - Fork 31
Move seed pod labelling to a separate controller #270
Move seed pod labelling to a separate controller #270
Conversation
7a27ee2
to
d43b391
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'll merge once e2e tests are passing
@@ -10,6 +10,8 @@ import ( | |||
|
|||
const ( | |||
TolerateUnreadyEndpointsAnnotationKey = "service.alpha.kubernetes.io/tolerate-unready-endpoints" | |||
SeedLabelKey = "navigator.jetstack.io/cassandra-seed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this name is more explicit
d43b391
to
d5047d0
Compare
Test failures were caused by single double quoted map keys in the jsonpath expression. |
d5047d0
to
8329a79
Compare
Try again, without the funky shell quoting. |
* In jetstack#256 I want to refactor nodepool.Sync so that its only responsibility is to update the NodePool status. * And the seed labelling seems like it is a separate concern that can live in its own module. * With its own unit tests.
8329a79
to
e23ce4e
Compare
Use a label selector instead. |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Release note: