Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

WIP: cassandra upgrade #277

Closed
wants to merge 21 commits into from
Closed

WIP: cassandra upgrade #277

wants to merge 21 commits into from

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Mar 6, 2018 •
edited

Fixes: #257

Release note:

NONE

@jetstack-ci-bot
Copy link
Contributor

@wallrj PR needs rebase

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kragniz

Assign the PR to them by writing /assign @kragniz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wallrj wallrj mentioned this pull request Apr 5, 2018
Closed
wallrj added 14 commits April 6, 2018 15:00
@wallrj
Add a Cassandra upgrade mechanism
5942ef2 
* Add a NodePool.Status.Version attribute which has the lowest reported version from all the pilots in the pool.
* Or nil, if the pilot failed to query its Cassandra database for its version.
* Calculate an UpdateVersion action if the desired Cassandra version is higher than the version reported for a NodePool.
* NodePools are upgraded one at a time.
* Pods within a Nodepool are upgraded one at a time, using a rolling update strategy without any partitioning.
* Upgrades are performed before any extra Nodepools are created and before nodepool scale out.

Fixes: jetstack#257
@wallrj
Add documentation
19a3571
@wallrj
Attempt to get more debug output
9986345
@wallrj
./hack/update-lint.sh
f66a620
@wallrj
dep ensure -no-vendor -v
d737e77
@wallrj
Wrap errors in createnodepool too
585d596
@wallrj
test for an upgrade event
49eaaf5
@wallrj
Log the action.
c3b518c
@wallrj
Set the NodePool label on pilots.
3142361
@wallrj
Add tests for upgrades
9fdecd7
@wallrj
Prevent major version upgrades
7531157
@wallrj
Add unit tests for update_version action
0d64ffb
@wallrj
Add E2E tests for nodepool status version reporting.
dbc2640
@wallrj
Add version change validation
d3f73ea
wallrj added a commit to wallrj/navigator that referenced this pull request Apr 10, 2018
@wallrj
Add validation to only allow Cassandra major version 3
9af030e 
* Only allow versions >= 3.0.0 && < 4.0.0
* Dissallow version changes in API updates (pending jetstack#277)
* Document the supported versions.

Fixes: jetstack#320
@wallrj wallrj mentioned this pull request Apr 10, 2018
Merged
@jetstack-bot
Copy link
Collaborator

@wallrj: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Collaborator

@wallrj: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
navigator-quick-verify c4fd2e7 link /test verify
navigator-e2e-v1-7 c4fd2e7 link /test e2e v1.7
navigator-e2e-v1-8 c4fd2e7 link /test e2e v1.8
navigator-e2e-v1-9 c4fd2e7 link /test e2e v1.9

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj
Copy link
Member Author

wallrj commented May 9, 2018

Supplanted by #352

@wallrj wallrj closed this May 9, 2018
@wallrj wallrj deleted the 257-cassandra-upgrade branch May 9, 2018 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kragniz kragniz Awaiting requested review from kragniz

@munnerz munnerz Awaiting requested review from munnerz

Assignees
No one assigned
Labels
do-not-merge/work-in-progress feature/upgrade needs-rebase release-note-none size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wallrj @jetstack-ci-bot @jetstack-bot @munnerz