This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Pilot executes cassandra
directly, bypassing the container image entry point
#347
Open
wallrj
wants to merge
9
commits into
jetstack:master
Choose a base branch
from
wallrj:346-exec-cassandra
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
69a59e5
Add a `pilot --leader-elect` flag
wallrj 20deca2
A helper for generating test files and directories.
wallrj 350c038
An integration test for Pilot WriteConfig.
wallrj 330437b
Add Pilot command line arguments for all the configuration values
wallrj 2426e2c
A configuration package for modifying yaml and properties files.
wallrj a25029d
Use the Configuration API to modify configuration files.
wallrj 74bb244
Run the Cassandra process as the Cassandra user (999) and update the …
wallrj 641310c
documentation
wallrj 015c813
dep ensure -v
wallrj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,4 @@ | |
.generate_exes | ||
.get_deps | ||
bin/ | ||
**/.test/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
package testfs | ||
|
||
import ( | ||
"fmt" | ||
"io/ioutil" | ||
"os" | ||
"path" | ||
"path/filepath" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
type TestFs struct { | ||
t *testing.T | ||
d string | ||
} | ||
|
||
func New(t *testing.T) *TestFs { | ||
d := fmt.Sprintf(".test/%s", t.Name()) | ||
d, err := filepath.Abs(d) | ||
require.NoError(t, err) | ||
err = os.RemoveAll(d) | ||
if err != nil && !os.IsNotExist(err) { | ||
t.Fatalf("Error while removing old test directory: %s", err) | ||
} | ||
|
||
err = os.MkdirAll(d, os.ModePerm) | ||
require.NoError(t, err) | ||
|
||
return &TestFs{ | ||
t: t, | ||
d: d, | ||
} | ||
} | ||
|
||
func (tfs *TestFs) TempPath(name string) string { | ||
outPath := path.Join(tfs.d, name) | ||
tmpFile, err := ioutil.TempFile(tfs.d, name) | ||
require.NoError(tfs.t, err) | ||
err = tmpFile.Close() | ||
require.NoError(tfs.t, err) | ||
err = os.Rename(tmpFile.Name(), outPath) | ||
require.NoError(tfs.t, err) | ||
return outPath | ||
} | ||
|
||
func (tfs *TestFs) TempDir(name string) string { | ||
outPath := path.Join(tfs.d, name) | ||
err := os.MkdirAll(outPath, os.ModePerm) | ||
require.NoError(tfs.t, err) | ||
return outPath | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the reasoning for this package? It seems to wrap |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for specifying a custom base, instead of relying on
ioutil
to pick the correct OS-specific tmp dir?