This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Use local volumes instead of hostpath volumes #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallrj
changed the title
kragniz
approved these changes
Jun 6, 2018
| 'jsonpath={range $.items[*]}{.metadata.name} {.spec.taints[*].effect}{"\n"}{end}' \ | ||
| | grep -v NoSchedule) | ||
| local node_name | ||
| node_name=$(python -c 'import random,sys; print(random.choice(sys.argv[1:]))' $schedulable_nodes) |
There was a problem hiding this comment.
can we assume python's going to be installed?
There was a problem hiding this comment.
Probably, and we're eventually rewriting these tests in golang (#242) so this'll do for now.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localvolumes rather thanhostpathvolumes in our e2e tests.cassandradirectly, bypassing the container image entry point #347, where I'm bypassing the Docker image entrypoint script.chownto makecassandrauser the owner of/var/lib/cassandra, and then execsu cassandra cassandraPodSecurityContextandSecurityContextRunAsUserandFSGroup.FSGroupdoesn't work for HostPath volumes (Add FSGroup support to HostPath volumes. kubernetes/kubernetes#39438)localvolume provisioner does applyFSGroupwhen mounting the volume.Fixes: #351
Release note: