This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Use hub in after inits of multi cluster environments #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
release-note
jetstack-bot
added
dco-signoff: yes
simonswine
changed the title
simonswine
reviewed
Oct 23, 2018
pkg/tarmak/provider/amazon/amazon.go
Outdated
| if a.tarmak.Cluster() != nil { | ||
| if err := a.verifyInstanceTypes(); err != nil { | ||
| result = multierror.Append(result, err) | ||
| } |
There was a problem hiding this comment.
Can get rid of this and discuss it in #559
|
/assign @alljames |
jetstack-bot
added
size/S
alljames
force-pushed
the
556-tarmak-init
branch
from
75a01be
to
52bb2cb
Compare
simonswine
reviewed
Nov 9, 2018
pkg/tarmak/tarmak.go
Outdated
| // ensure that the tarmak cli is pointing to that environment's 'hub' cluster | ||
| // resource, else set point tarmak cli to newly-initialised cluster | ||
| switch cluster.Type() { | ||
| case "cluster-multi": |
There was a problem hiding this comment.
we should use a constant here
… default on new multicluster Signed-off-by: Aled James <aledjms@gmail.com>
Signed-off-by: Aled James <aledjms@gmail.com>
Signed-off-by: Aled James <aledjms@gmail.com>
alljames
force-pushed
the
556-tarmak-init
branch
from
2e3f82b
to
873318e
Compare
|
/unassign |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes
tarmak initpanics when run against empty ~/.tarmakWhich issue this PR fixes fixes #556
Release note: