Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Use vault-helper dry run ensure #572

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Use vault-helper dry run ensure #572

merged 3 commits into from
Nov 28, 2018

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Oct 5, 2018 

Use vault-helper dry run ensure

/assign
/hold

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 5, 2018
@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 5, 2018
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Oct 5, 2018

/hold cancel
/unassign
/assign @simonswine

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018
@simonswine
Copy link
Contributor

I am not too sure if this is expected

  • Created cluster with this PR
  • Ran tarmak cluster plan. no changes
  • SSH into vault and removed k8s secret backend: vault secrets disable <env>-cluster/pki/k8s
  • Ran tarmak cluster plan, changes but not on the cluster resource
  • Ran tarmak cluster plan. no changes

So there is definitely something going on, not just a dry run

/assign @JoshVanL
/unassign
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2018
@JoshVanL
Use vault-helper dry run ensure
28223f0 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Only warn when can't connect to bastion
1e5b523 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Only vault.Ensure() when applying and prevent write races
c08cb7f 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2018
@JoshVanL
Copy link
Contributor Author

@simonswine this behavior should now be fixed

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Oct 25, 2018
@simonswine simonswine added this to the release-0.6 milestone Nov 26, 2018
@simonswine simonswine added this to Needs review in release-0.6 Nov 26, 2018
@simonswine
Copy link
Contributor

/approve
/lgtm

Thanks @JoshVanL, works fine for me

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@simonswine
Copy link
Contributor

/unhold

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@simonswine simonswine removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@simonswine simonswine removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@simonswine simonswine self-requested a review November 28, 2018 11:23
simonswine
simonswine approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/unhodl

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@simonswine simonswine closed this Nov 28, 2018
@simonswine simonswine reopened this Nov 28, 2018
@jetstack-bot jetstack-bot merged commit c3425e4 into jetstack:master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine approved these changes

@kragniz kragniz Awaiting requested review from kragniz

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
release-0.6
  
Needs review
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @simonswine @jetstack-bot