Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds ability to change vault-helper url in tarmak.yaml #619

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Adds ability to change vault-helper url in tarmak.yaml #619

merged 3 commits into from
Nov 28, 2018

Conversation

JoshVanL
Copy link
Contributor

What this PR does / why we need it:
Adds option to set a custom vault-helper download url. Still defaults to normal github location without the option set.

fixes #393

Adds custom vault-helper URL option in tarmak.yaml

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2018
@JoshVanL
Copy link
Contributor Author

/assign @simonswine

@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2018
@JoshVanL JoshVanL changed the title Adds ability to change vault url in tarmak.yaml Adds ability to change vault-helper url in tarmak.yaml Nov 13, 2018
@simonswine simonswine added this to the release-0.6 milestone Nov 14, 2018
@JoshVanL JoshVanL mentioned this pull request Nov 19, 2018
Closed
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2018
@simonswine simonswine added this to In progress in release-0.6 Nov 23, 2018
@JoshVanL
Adds ability to change vault url in tarmak.yaml
7b7492b 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Updates api reference docs
7853480 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 23, 2018
@simonswine simonswine moved this from In progress to Needs review in release-0.6 Nov 26, 2018
simonswine
simonswine suggested changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @JoshVanL
/unassign

/approve

docs/user-guide.rst Outdated

clusters:
- amazon:
ebsEncrypted: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too sure this amazon block might be misleading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonswine In what way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonswine In what way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have the amazon.ebsEncrypted there, it has nothing to do with vault-helper and might confuse people

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Nov 28, 2018
@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@JoshVanL
Removes misleading ebsEncrypted block from example docs
9268d2c 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Nov 28, 2018
@simonswine
Copy link
Contributor

Thanks @JoshVanL
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit f065731 into jetstack:master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine approved these changes

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
release-0.6
  
Needs review
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Customize vault-helper download URL
3 participants
@JoshVanL @simonswine @jetstack-bot