Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add Heptio Ark example in docs #657

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Add Heptio Ark example in docs #657

merged 2 commits into from
Jan 29, 2019

Conversation

alljames
Copy link
Contributor

@alljames alljames commented Dec 9, 2018

Signed-off-by: Aled James aledjms@gmail.com

What this PR does / why we need it:
Adds Heptio Ark example to documentation
fixes #430

Special notes for your reviewer:

Release note:

Add Heptio Ark example to documentation

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/documentation Categorizes issue or PR as related to documentation. labels Dec 9, 2018
@simonswine simonswine added this to the release-0.6 milestone Dec 10, 2018
@alljames
Copy link
Contributor Author

/retest

@alljames
Copy link
Contributor Author

/test verify quick

@simplyzee
Copy link

/lgtm
/assign @simonswine
/unassign

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2018
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2018
@simonswine
Copy link
Contributor

/assing @zee-ahmed

Can you rebase that for me?

@simonswine simonswine assigned simplyzee and alljames and unassigned simonswine and simplyzee Jan 3, 2019
@simonswine
Copy link
Contributor

Ah sorry @zee-ahmed, it's @alljames' PR

@jetstack-bot jetstack-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2019
@alljames
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned alljames Jan 15, 2019
@alljames @simonswine
Add Heptio Ark example in docs
0d448db 
Signed-off-by: Aled James <aledjms@gmail.com>
@alljames @simonswine
Fix docs example for Ark based on zee-ahmed feedback
99cd0b4 
Signed-off-by: Aled James <aledjms@gmail.com>
@simonswine
Copy link
Contributor

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alljames, simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@jetstack-bot jetstack-bot merged commit 89c45d7 into jetstack:master Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simplyzee simplyzee Awaiting requested review from simplyzee

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

Provide instructions how to run ark in docs
4 participants
@alljames @simplyzee @simonswine @jetstack-bot