This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Fix error when running kube commands with public API #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running tarmak kubeconfig/kubectl with a public ELB in front of apiserver, it gives errors. This comes down to not setting the certificate. This fixes that. Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
jetstack-bot
added
release-note
|
/assign @JoshVanL |
jetstack-bot
added
size/M
|
Can you cherry-pick that instead of updating the js assets? |
|
@MattiasGees Was able to reproduce 😬 |
MattiasGees
force-pushed
the
bug/kube-public-elb
branch
from
067fbf8
to
38c9671
Compare
jetstack-bot
added
size/XS
This was referenced Dec 14, 2018
|
Done |
|
/lgtm |
simonswine
added
cherrypick-approved
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
simonswine
added
the
status/approved-for-milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running tarmak kubeconfig/kubectl with a public ELB in front of apiserver, it gives errors. This comes down to not setting the certificate. This fixes that.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #659Special notes for your reviewer:
Release note: