Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Enables wing-dev-mode on bastion instances #678

Merged
merged 4 commits into from
Jan 14, 2019

Conversation

JoshVanL
Copy link
Contributor

Enable `--wing-dev-mode` on bastion instances for Wing development

/assign

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2019
@jetstack-bot jetstack-bot added the area/terraform Indicates a PR is affecting Terraform configuration label Jan 10, 2019
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 10, 2019
@simonswine
Copy link
Contributor

I am having some issues destroying the thing again:

DEBU[0380] 2 errors occurred:                            app=tarmak module=terraform std=err
DEBU[0380]      * module.kubernetes.aws_iam_policy_attachment.wing_binary_read (destroy): 1 error occurred:  app=tarmak module=terraform std=err
DEBU[0380]      * aws_iam_policy_attachment.wing_binary_read: [WARN] Error removing user, role, or group list from IAM Policy Detach csire-cluster-wing-binary:  app=tarmak module=terraform std=err
DEBU[0380] – NoSuchEntity: Policy arn:aws:iam::228615251467:policy/bastion.csire-cluster.wing_binary_read was not found.  app=tarmak module=terraform std=err
DEBU[0380]      status code: 404, request id: 627c1585-158a-11e9-8bb1-939f55c828e0  app=tarmak module=terraform std=err
DEBU[0380]                                               app=tarmak module=terraform std=err
DEBU[0380]                                               app=tarmak module=terraform std=err
DEBU[0380]      * module.vault.aws_iam_policy_attachment.wing_binary_read (destroy): 1 error occurred:  app=tarmak module=terraform std=err
DEBU[0380]      * aws_iam_policy_attachment.wing_binary_read: [WARN] Error removing user, role, or group list from IAM Policy Detach csire-cluster-wing-binary:  app=tarmak module=terraform std=err
DEBU[0380] – NoSuchEntity: Policy arn:aws:iam::228615251467:policy/bastion.csire-cluster.wing_binary_read was not found.  app=tarmak module=terraform std=err
DEBU[0380]      status code: 404, request id: 5dbfedb0-158a-11e9-9c43-115e0575bb14  app=tarmak module=terraform std=err

Are you able to reproduce it?

/assign @JoshVanL
/unassign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 11, 2019
@JoshVanL
Copy link
Contributor Author

@simonswine
Yeah sorry about that I am. Have a fix so will add shortly.
This is an issue with using multiple attachments on the same policy across roles.
Using iam_role_policy_attachment instead fixes the issue

@JoshVanL
Copy link
Contributor Author

hashicorp/terraform#5979

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 11, 2019
@simonswine
Copy link
Contributor

Jan 11 13:51:01 ip-10-99-32-10.eu-west-1.compute.internal sh[5416]: fatal error: An error occurred (403) when calling the HeadObject operation: Forbidden
Jan 11 13:50:25 bastion.develop.tarmak.org sh[5104]: fatal error: An error occurred (403) when calling the HeadObject operation: Forbidden

Both bastion and vault-1 fail

/assign @JoshVanL
/unassign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 11, 2019
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 11, 2019
@simonswine
Copy link
Contributor

Thank you very much @JoshVanL, seems to work prefect now
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2019
@jetstack-bot jetstack-bot merged commit d8836fd into jetstack:master Jan 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Indicates a PR is affecting Terraform configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants