This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Implement kube addon manager #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
from
67322d7
to
3e185eb
Compare
jetstack-bot
added
dco-signoff: yes
|
/assign @simonswine |
|
There seems to be a race between the masters (so somehow the election of kube-addon-managers and/or cluster-manager is not stable. This is from a cluster with three master nodes: diff between the two RSs is: /assign @JoshVanL |
|
/test puppet-tarmak-acceptance-centos v1.11 |
…rmak Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
from
235d09b
to
91d147c
Compare
jetstack-bot
added
the
approved
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
6 times, most recently
from
e84410b
to
845caeb
Compare
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
from
845caeb
to
4698a8b
Compare
|
/unassign |
simonswine
suggested changes
Jan 29, 2019
There was a problem hiding this comment.
Just some minor bits now. The question is how sure are we that we did not forget the labe anywhere
/assign @JoshVanL
/unassign
| Service[$service_apiserver], | ||
| ] | ||
|
|
||
| $command = "/bin/bash -c \"while true; do if [[ \$(curl -k -w '%{http_code}' -s -o /dev/null ${protocol}://localhost:${server_port}/healthz) == 200 ]]; then break; fi; done; kubectl apply -f '${apply_file}' || rm -f '${apply_file})'\"" |
There was a problem hiding this comment.
Maybe we add a sleep 2 or something, as this might be quite a few connections on bulk.
There was a problem hiding this comment.
Yep, good idea. I did at one point during testing but must have removed it...
| @@ -25,6 +27,8 @@ apiVersion: rbac.authorization.k8s.io/v1beta1 | |||
| kind: ClusterRoleBinding | |||
| metadata: | |||
| name: calico-node | |||
| labels: | |||
| addonmanager.kubernetes.io/mode: EnsureExists | |||
There was a problem hiding this comment.
Just a bit below: ServiceAccount is missing the label addonmanager.kubernetes.io/mode
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
2 times, most recently
from
d6ffd73
to
0cf167e
Compare
|
/unassign |
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
JoshVanL
force-pushed
the
implement-kube-addon-manager
branch
from
0cf167e
to
d42f35b
Compare
|
/test puppet-tarmak-acceptance-ubuntu v1.11 |
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
|
/test puppet-tarmak-acceptance-centos v1.11 |
|
/test puppet-tarmak-acceptance-ubuntu v1.11 |
|
Good work /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test puppet-fluent_bit-acceptance |
|
/test puppet-tarmak-acceptance-centos v1.13 |
|
/test puppet-tarmak-acceptance-ubuntu v1.11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses kube addon-manager to manage the life cycle of resources created by tarmak.
fixes #665