-
Notifications
You must be signed in to change notification settings - Fork 49
Remove VPC endpoints from being created in existing VPC #707
Remove VPC endpoints from being created in existing VPC #707
Conversation
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
/assign @simonswine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
@@ -5,7 +5,7 @@ resource "aws_route53_zone" "private" { | |||
comment = "Hosted zone for private kubernetes in ${var.environment}" | |||
|
|||
vpc { | |||
vpc_id = "${aws_vpc.main.0.id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we not see this error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we didn't use an existing VPC since we updated terraform and so used the new variable assignments. Something to look out for
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoshVanL, simonswine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #706
This removes this VPC endpoint from being created, along with a warning in the docs that it is strongly recommended that one exists.