Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix wing hashing and cleanup versioning #711

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Fix wing hashing and cleanup versioning #711

merged 2 commits into from
Jan 31, 2019

Conversation

simonswine
Copy link
Contributor 

NONE

Some more cleanup of versioning, wing hashing

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 31, 2019
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 31, 2019
@JoshVanL
Copy link
Contributor

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Jan 31, 2019
@simonswine
Remove unused legacy version struct
c256561 
Signed-off-by: Christian Simon <simon@swine.de>
@simonswine
Generate wing hash based on vendored file
091a3ab 
Signed-off-by: Christian Simon <simon@swine.de>
@jetstack-bot jetstack-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 31, 2019
@simonswine
Copy link
Contributor Author

/unassign
/assign @JoshVanL

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Jan 31, 2019
@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2019
@jetstack-bot jetstack-bot merged commit 20ee03d into jetstack:master Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonswine @jetstack-bot @JoshVanL