Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Remove etcd services when using calico Kubernetes backend #724

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Remove etcd services when using calico Kubernetes backend #724

merged 1 commit into from
Feb 7, 2019

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Feb 7, 2019 

NONE

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Feb 7, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/puppet Indicates a PR is affecting Puppet manifests kind/documentation Categorizes issue or PR as related to documentation. labels Feb 7, 2019
@JoshVanL JoshVanL force-pushed the kubernetes-no-overlay-etcd branch 3 times, most recently from 28e681b to 6a6e0ce Compare February 7, 2019 16:12
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Feb 7, 2019

/unassign
/assign @simonswine

@JoshVanL JoshVanL changed the title WIP: Remove etcd services when using calico Kubernetes backend Remove etcd services when using calico Kubernetes backend Feb 7, 2019
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019
@JoshVanL @simonswine
Disable etcd-overlay in calico kubernetes backend mode
5d18a82 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2019
@simonswine
Copy link
Contributor

/lgtm

1 similar comment
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@jetstack-bot jetstack-bot merged commit 9fed62d into jetstack:master Feb 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dippynark dippynark Awaiting requested review from dippynark

@simonswine simonswine Awaiting requested review from simonswine

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @simonswine