Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Set additional IAM policies correctly for all roles #727

Conversation

simonswine
Copy link
Contributor

Non-kubernetes instance did not receive those parameters correctly. This
PR makes sure they are set correctly in the terraform vars file.

Signed-off-by: Christian Simon simon@swine.de

Fixes additional IAM policies correctly for non kubernetes roles

Non-kubernetes instance did not receive those parameters correctly. This
PR makes sure they are set correctly in the terraform vars file.

Signed-off-by: Christian Simon <simon@swine.de>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Feb 7, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2019
@jetstack-bot jetstack-bot added the area/terraform Indicates a PR is affecting Terraform configuration label Feb 7, 2019
@JoshVanL
Copy link
Contributor

JoshVanL commented Feb 8, 2019

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2019
@jetstack-bot jetstack-bot merged commit b51b1e9 into jetstack:master Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/terraform Indicates a PR is affecting Terraform configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants