Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Have timeout for tunnel, new connections reset timer #730

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Have timeout for tunnel, new connections reset timer #730

merged 2 commits into from
Feb 12, 2019

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Feb 8, 2019 •
edited

/assign

SSH tunnel have a timeout of 10 mins. Any new connections will disable this timer. Once that connection is closed the timeout is reset to 10 mins unless there is another open connection.

ixes #723

SSH tunnels timeout after 10 minutes of inactivity.

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 8, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@JoshVanL JoshVanL changed the title WIP: Have timeout for tunnel, new connections reset timer Have timeout for tunnel, new connections reset timer Feb 8, 2019
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2019
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Feb 8, 2019

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Feb 8, 2019
@JoshVanL JoshVanL changed the title Have timeout for tunnel, new connections reset timer Have timeout for tunnel, new connections reset timer / re-use ssh tunnels Feb 8, 2019
@JoshVanL JoshVanL force-pushed the ssh-tunnel-improvments branch 2 times, most recently from db97b16 to 2c500ea Compare February 11, 2019 14:40
@JoshVanL JoshVanL changed the title Have timeout for tunnel, new connections reset timer / re-use ssh tunnels Have timeout for tunnel, new connections reset timer Feb 11, 2019
@simonswine
Copy link
Contributor

simonswine commented Feb 12, 2019 •
edited

Needs rebase, works well for continued kubectl get. But in those cases we are not cleaning up correctly:

~/.golang/packages/bin/gops 26231                                                                                                                                                                                                      christian-xps: Tue Feb 12 11:32:40 2019

parent PID:     4654
threads:        13
memory usage:   0.316%
cpu usage:      0.623%
username:       christian
cmd+args:       /home/christian/.golang/packages/src/github.com/jetstack/tarmak/_output/tarmak tunnel api.csire-cluster.tarmak.local 6443 43189
local/remote:   127.0.0.1:43189 <-> 0.0.0.0:0 (LISTEN)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48004 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47988 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47990 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48014 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48032 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48030 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47976 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48010 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48078 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48080 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48024 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48036 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48026 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48060 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47974 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48074 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47982 (ESTABLISHED)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48056 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47978 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48012 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47984 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48002 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48062 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48018 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47980 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48066 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48052 (CLOSE_WAIT)
local/remote:   172.20.72.112:46386 <-> 63.35.82.236:22 (ESTABLISHED)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48020 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48006 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48022 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48072 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48008 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48048 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48076 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48068 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47986 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48038 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48000 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47992 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48028 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:47998 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48046 (CLOSE_WAIT)
local/remote:   127.0.0.1:43189 <-> 127.0.0.1:48042 (CLOSE_WAIT)

@simonswine
Copy link
Contributor

/assign @JoshVanL
/unassign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Feb 12, 2019
@JoshVanL
Have timeout for tunnel, new connections reset timer
e2e5a2d 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Close tunnel connections correctly after transmission
d3fe1b8 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Feb 12, 2019
@simonswine
Copy link
Contributor

Thanks that solves it

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@jetstack-bot jetstack-bot merged commit a662f32 into jetstack:master Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@opeyemi33171 opeyemi33171 Awaiting requested review from opeyemi33171

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @simonswine