Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add config toggle for heapster, influxdb, grafana #740

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Add config toggle for heapster, influxdb, grafana #740

merged 1 commit into from
Feb 12, 2019

Conversation

JoshVanL
Copy link
Contributor

Current clusters will have these enabled by default.
Newly created clusters through init has them toggled false.

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

/assign @simonswine
/fixes #718

Adds option to toggle Grafana, Heapster and InfluxDB, defaulting to false for all newly created clusters.

@JoshVanL
Add config toggle for heapster, influxdb, grafana
17186d3 
Current clusters will have these enabled by default.
Newly created clusters through init has them toggled false.

Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2019
@jetstack-bot jetstack-bot added area/puppet Indicates a PR is affecting Puppet manifests kind/documentation Categorizes issue or PR as related to documentation. labels Feb 12, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@JoshVanL
Copy link
Contributor Author

`/test puppet-tarmak-acceptance-ubuntu v1.11

@JoshVanL
Copy link
Contributor Author

/test puppet-tarmak-acceptance-ubuntu v1.11

@simonswine
Copy link
Contributor

Thanks this works for me (I have not tested all combinations though)

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@jetstack-bot jetstack-bot merged commit 8b526d4 into jetstack:master Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alljames alljames Awaiting requested review from alljames

@dippynark dippynark Awaiting requested review from dippynark

@simonswine simonswine Awaiting requested review from simonswine

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Grafana, Heapster and Influx pods
3 participants
@JoshVanL @jetstack-bot @simonswine