Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add some basic e2e tests #743

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Add some basic e2e tests #743

merged 4 commits into from
Feb 22, 2019

Conversation

JoshVanL
Copy link
Contributor

/assign @simonswine
fixes #434

Create end to end tests in code

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 13, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@JoshVanL
Copy link
Contributor Author

/unassign @simonswine
/assign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Feb 13, 2019
@JoshVanL JoshVanL force-pushed the e2e-integration-tests branch 3 times, most recently from d6800ba to e68f762 Compare February 13, 2019 17:40
@simonswine @JoshVanL
Add some basic e2e tests
558f674 
Add vendoring
Use environment destroy
Fixing vendor packages
Add e2e test command to makefile
Fix environment destroy
Add tarmak upgrade test
Fix go fmt
Fix makefile
Add kubernetes upgrade test
Refactor code a bit
Fix go fmt
Fix return statement
Refactor duplicate code
Get e2e versions programmatically

Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2019
@JoshVanL
Copy link
Contributor Author

/hold cance

@JoshVanL
Copy link
Contributor Author

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2019
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Feb 13, 2019
@jetstack-bot jetstack-bot added the area/puppet Indicates a PR is affecting Puppet manifests label Feb 15, 2019
@JoshVanL
Adds sobobuoy to end to end tests
3fc4919 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@MattiasGees MattiasGees mentioned this pull request Feb 18, 2019
Closed
simonswine
simonswine suggested changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few changes that would be great to get in

/assign @JoshVanL
/unassign

Currently running

Makefile Outdated
@@ -291,3 +291,21 @@ docker_%:

# remove container
docker rm $(CONTAINER_ID)

e2e-test-all-conformance: build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some help text comment so it shows up in make help?

cmd/tarmak/e2e/sonobuoy_test.go Outdated
}

if _, err := os.Stat(si.binPath); os.IsNotExist(err) {
t.Fatal("sonobuoy binary not exissing: ", si.binPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing

cmd/tarmak/e2e/sonobuoy_test.go Show resolved Hide resolved
@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Feb 21, 2019
@JoshVanL
Adds sonobuoy as depend in Makefile and adds help
0ecb663 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Feb 21, 2019
simonswine
simonswine suggested changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me more insight why all those changes are necessary?. They seem to be quite high risk that short before release

packer/amazon/centos-puppet-agent-latest-kernel.json Outdated
@@ -26,7 +26,7 @@
"ssh_username": "centos",
"ssh_pty": "true",
"encrypt_boot": "{{user `ebs_volume_encrypted`}}",
"ami_name": "Tarmak CentOS 7 x86_64 with puppet-agent and latest upstream kernel{{isotime \"2006-01-02_030405\"}}",
"ami_name": "{{user `tarmak_environment`}} - Tarmak CentOS 7 x86_64 with puppet-agent and latest upstream kernel{{isotime \"2006-01-02_030405\"}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that change necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, change came from rebase, will revert

packer/amazon/centos-puppet-agent.json Outdated
@@ -26,7 +26,7 @@
"ssh_username": "centos",
"ssh_pty": "true",
"encrypt_boot": "{{user `ebs_volume_encrypted`}}",
"ami_name": "Tarmak CentOS 7 x86_64 with puppet-agent {{isotime \"2006-01-02_030405\"}}",
"ami_name": "{{user `tarmak_environment`}} - Tarmak CentOS 7 x86_64 with puppet-agent {{isotime \"2006-01-02_030405\"}}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that change necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, change came from rebase, will revert

puppet/modules/kubernetes/manifests/dns.pp
@@ -31,18 +31,18 @@
$post_1_10 = versioncmp($::kubernetes::version, '1.10.0') >= 0

if $post_1_10 {
$app_name = 'core-dns'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that name change down to sonobouy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, guess we should consider it source of truth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure kube-dns is the correct name for it though

@simonswine
Copy link
Contributor

/assign @JoshVanL
/unassign

@jetstack-bot jetstack-bot assigned JoshVanL and unassigned simonswine Feb 22, 2019
@JoshVanL
Revert changes to AMI names
ab2aca0 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

/unassign
/assign @simonswine

@jetstack-bot jetstack-bot assigned simonswine and unassigned JoshVanL Feb 22, 2019
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2019
@jetstack-bot jetstack-bot merged commit 86b3412 into jetstack:master Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine requested changes

@wallrj wallrj Awaiting requested review from wallrj

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full e2e test that builds a single and multi cluster on AWS
3 participants
@JoshVanL @jetstack-bot @simonswine