Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Fix Terraform bug #763

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Fix Terraform bug #763

merged 2 commits into from
Mar 11, 2019

Conversation

MattiasGees
Copy link
Member

What this PR does / why we need it
Terraform has a bug where changes aren't processed when ignore_changes is active for other attributes. The PR hashicorp/terraform#17856 fixes this but isn't merged. I created a fork of Terraform 0.11.11 and merged in that fix.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Fix bug with Terraform that causes problems on Tarmak upgrades.

Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2019
@jetstack-bot jetstack-bot requested a review from wallrj March 8, 2019 16:53
@MattiasGees
Copy link
Member Author

/assign @simonswine

@simonswine simonswine added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager label Mar 11, 2019
@simonswine simonswine added this to the v0.6 milestone Mar 11, 2019
@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2019
@simonswine simonswine added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: MattiasGees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 56b497a into jetstack:master Mar 11, 2019
jetstack-bot added a commit that referenced this pull request Mar 13, 2019
…3-upstream-release-0.6

Automated cherry pick of #763
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants