Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Detect existing datacenter #766

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Detect existing datacenter #766

merged 2 commits into from
Mar 13, 2019

Conversation

simonswine
Copy link
Contributor 

Set correct datacenter in consul and respect existing datacenters

MattiasGees and others added 2 commits March 13, 2019 14:33
@MattiasGees @simonswine
Change injection of region
a423f17 
Signed-off-by: Mattias Gees <mattias.gees@gmail.com>
@simonswine
Detect previous datacenter setting for consul
14109f0 
Signed-off-by: Christian Simon <simon@swine.de>
@simonswine simonswine self-assigned this Mar 13, 2019
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2019
@jetstack-bot jetstack-bot added the area/puppet Indicates a PR is affecting Puppet manifests label Mar 13, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@simonswine
Copy link
Contributor Author

/test puppet-consul-acceptance-three-node

@simonswine simonswine assigned JoshVanL and unassigned simonswine Mar 13, 2019
@simonswine simonswine mentioned this pull request Mar 13, 2019
Merged
@simonswine simonswine added this to the v0.6 milestone Mar 13, 2019
@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2019
@simonswine
Copy link
Contributor Author

/test puppet-consul-acceptance-single-node

@jetstack-bot jetstack-bot merged commit b40ca5c into jetstack:master Mar 13, 2019
@simonswine simonswine mentioned this pull request Mar 13, 2019
Closed
jetstack-bot added a commit that referenced this pull request Mar 13, 2019
@jetstack-bot
Merge pull request #769 from simonswine/automated-cherry-pick-of-#766-#…
4b1cd9a 
…767-#768-release-0.6

Automated cherry pick of #766 #767 #768
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dippynark dippynark Awaiting requested review from dippynark

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonswine @jetstack-bot @JoshVanL @MattiasGees