Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds update deploy permissions for metrics-server-nanny #791

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Adds update deploy permissions for metrics-server-nanny #791

merged 3 commits into from
Apr 10, 2019

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Apr 1, 2019

Signed-off-by: JoshVanL vleeuwenjoshua@gmail.com

What this PR does / why we need it:
Adds update permissions to metrics-server-nanny so that it is able to change the metrics-server deployment.

Adds deployment update permissions to metrics-server-nanny container

/assign @simonswine

@JoshVanL
Adds update deploy permissions for metrics-server-nanny
2452a14 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 1, 2019
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/puppet Indicates a PR is affecting Puppet manifests labels Apr 1, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2019
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Apr 1, 2019

/test puppet-tarmak-acceptance-centos v1.14

@JoshVanL
Change metrics-server deployment to an 'EnsureExists'
a5ef3a1 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL
Removes resources from metrics-pod
f950c70 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
@simonswine
Copy link
Contributor

/test puppet-tarmak-acceptance-centos v1.14

@simonswine simonswine closed this Apr 10, 2019
@simonswine simonswine reopened this Apr 10, 2019
@jetstack-bot
Copy link
Collaborator

@JoshVanL: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-puppet-module-tarmak-acceptance-1-14-centos f950c70 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonswine
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@jetstack-bot jetstack-bot merged commit 9e9e3ad into jetstack:master Apr 10, 2019
@simonswine
Copy link
Contributor

@JoshVanL can you prepare a cherry-pick?

jetstack-bot added a commit that referenced this pull request Apr 11, 2019
@jetstack-bot
Merge pull request #793 from JoshVanL/automated-cherry-pick-of-#791-o…
a47e977 
…rigin-release-0.6

Automated cherry pick of #791 origin release 0.6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dippynark dippynark Awaiting requested review from dippynark

Assignees

@simonswine simonswine

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/puppet Indicates a PR is affecting Puppet manifests cherrypick-candidate dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @simonswine