Merge pull request ggerganov#6 from bobqianic/fix-binding

Fix binding
jettoblack · Feb 5, 2024 · 9fbe59f · 9fbe59f
2 parents b3305eb + 4cc4b89
commit 9fbe59f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 19 deletions.
diff --git a/bindings/go/params.go b/bindings/go/params.go
@@ -19,10 +19,6 @@ func (p *Params) SetTranslate(v bool) {
 	p.translate = toBool(v)
 }
 
-func (p *Params) SetSplitOnWord(v bool) {
-	p.split_on_word = toBool(v)
-}
-
 func (p *Params) SetNoContext(v bool) {
 	p.no_context = toBool(v)
 }

diff --git a/bindings/ruby/ext/ruby_whisper.cpp b/bindings/ruby/ext/ruby_whisper.cpp
@@ -305,12 +305,6 @@ static VALUE ruby_whisper_params_get_token_timestamps(VALUE self) {
 static VALUE ruby_whisper_params_set_token_timestamps(VALUE self, VALUE value) {
   BOOL_PARAMS_SETTER(self, token_timestamps, value)
 }
-static VALUE ruby_whisper_params_get_split_on_word(VALUE self) {
-  BOOL_PARAMS_GETTER(self, split_on_word)
-}
-static VALUE ruby_whisper_params_set_split_on_word(VALUE self, VALUE value) {
-  BOOL_PARAMS_SETTER(self, split_on_word, value)
-}
 static VALUE ruby_whisper_params_get_speed_up(VALUE self) {
   BOOL_PARAMS_GETTER(self, speed_up)
 }
@@ -406,8 +400,6 @@ void Init_whisper() {
   rb_define_method(cParams, "suppress_non_speech_tokens=", ruby_whisper_params_set_suppress_non_speech_tokens, 1);
   rb_define_method(cParams, "token_timestamps", ruby_whisper_params_get_token_timestamps, 0);
   rb_define_method(cParams, "token_timestamps=", ruby_whisper_params_set_token_timestamps, 1);
-  rb_define_method(cParams, "split_on_word", ruby_whisper_params_get_split_on_word, 0);
-  rb_define_method(cParams, "split_on_word=", ruby_whisper_params_set_split_on_word, 1);
   rb_define_method(cParams, "speed_up", ruby_whisper_params_get_speed_up, 0);
   rb_define_method(cParams, "speed_up=", ruby_whisper_params_set_speed_up, 1);
   rb_define_method(cParams, "diarize", ruby_whisper_params_get_diarize, 0);

diff --git a/bindings/ruby/tests/test_whisper.rb b/bindings/ruby/tests/test_whisper.rb
@@ -110,13 +110,6 @@ def test_token_timestamps
     assert !@params.token_timestamps
   end
 
-  def test_split_on_word
-    @params.split_on_word = true
-    assert @params.split_on_word
-    @params.split_on_word = false
-    assert !@params.split_on_word
-  end
-
   def test_speed_up
     @params.speed_up = true
     assert @params.speed_up