Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CrossOriginHandler #10220

Closed
sbordet opened this issue Aug 3, 2023 · 1 comment · Fixed by #11093
Closed

Implement CrossOriginHandler #10220

sbordet opened this issue Aug 3, 2023 · 1 comment · Fixed by #11093
Assignees
@sbordet
Labels
Enhancement

Comments

@sbordet
Copy link
Contributor

sbordet commented Aug 3, 2023

Jetty version(s)
12

Enhancement Description
The functionality of CrossOriginFilter should be moved to a CrossOriginHandler.
It should be possible to add the CrossOriginHandler after a ServletContextHandler in case different web applications want to configure cross-origin differently.
@gregw
Copy link
Contributor

gregw commented Aug 4, 2023

It is now possible to add handles after ee10 ServletContextHandler.

However for ee8/9 it might be a bit more fiddly to insert a core handler in the right location

@joakime joakime moved this to 🏗 In progress in Jetty 12.0.2 FROZEN Sep 13, 2023
@joakime joakime removed this from Jetty 12.0.3 Oct 11, 2023
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.6 FROZEN Dec 22, 2023
sbordet added a commit that referenced this issue Dec 22, 2023
@sbordet
Fixes #10220 - Implement CrossOriginHandler.
4e99df9 
Introduced CrossOriginHandler.
Added cross-origin Jetty module.
Added CrossOriginHandler documentation to the programming guide.
Added CrossOriginHandler documentation to the operations guide.
Added cross-origin headers to the HttpHeader enum.
Added test cases.
Deprecated ee10 CrossOriginFilter.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Dec 22, 2023 that will close this issue
Fixes #10220 - Implement CrossOriginHandler. #11093
Merged
sbordet added a commit that referenced this issue Jan 12, 2024
@sbordet
Fixes #10220 - Implement CrossOriginHandler. (#11093)
a9e564a 
Introduced CrossOriginHandler.
Added cross-origin Jetty module.
Added CrossOriginHandler documentation to the programming guide.
Added CrossOriginHandler documentation to the operations guide.
Added cross-origin headers to the HttpHeader enum.
Added test cases.
Deprecated ee10 CrossOriginFilter.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.6 FROZEN Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbordet sbordet

Labels
Enhancement
Projects
No open projects
Jetty 12.0.6 FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10220 - Implement CrossOriginHandler. jetty/jetty.project
2 participants
@gregw @sbordet