Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpConfiguration dump is missing entries #12163

Closed
joakime opened this issue Aug 14, 2024 · 3 comments · Fixed by #12164
Closed

HttpConfiguration dump is missing entries #12163

joakime opened this issue Aug 14, 2024 · 3 comments · Fixed by #12164
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@joakime
Copy link
Contributor

joakime commented Aug 14, 2024

Jetty version(s)
12.0.12

Jetty Environment
Any

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description
When working issue #12162 it was noticed that the output of HttpConfiguration.dump is missing entries for things like HttpCompliance, UriCompliance, and MultipartCompliance (and probably others)

How to reproduce?
Run a new jetty-base with just http, and start it with start.jar jetty.server.dumpAfterStart=true and look at the output.

+= ServerConnector@17f2dd85{HTTP/1.1, (http/1.1)}{0.0.0.0:8080} - STARTED
|  +~ QueuedThreadPool[qtp1489069835]@58c1670b{STARTED,10<=27<=200,i=0,r=-1,t=59831ms,q=0}[ReservedThreadExecutor@a66e580{capacity=32,threads=ThreadIdPool@5b852b49{capacity=32}}] - STARTED
|  +~ oejut.ScheduledExecutorScheduler@2698dc7{STARTED} - STARTED
|  +~ org.eclipse.jetty.io.ArrayByteBufferPool@122d6c22{min=0,max=65536,buckets=16,heap=0/4022337536,direct=0/4022337536}
|  += HttpConnectionFactory@68b32e3e[HTTP/1.1] - STARTED
|  |  +- HttpConfiguration@7f93dd4e{32768/8192,8192/8192,https://:0,[]}
|  |     +> customizers size=0
|  |     +> formEncodedMethods size=2
|  |     |  +> POST
|  |     |  +> PUT
|  |     +> outputBufferSize=32768
|  |     +> outputAggregationSize=8192
|  |     +> requestHeaderSize=8192
|  |     +> responseHeaderSize=8192
|  |     +> headerCacheSize=1024
|  |     +> secureScheme=https
|  |     +> securePort=0
|  |     +> idleTimeout=-1
|  |     +> sendDateHeader=false
|  |     +> sendServerVersion=true
|  |     +> sendXPoweredBy=false
|  |     +> delayDispatchUntilContent=true
|  |     +> persistentConnectionsEnabled=true
|  |     +> maxErrorDispatches=10
|  |     +> minRequestDataRate=0
|  |     +> minResponseDataRate=0
|  |     +> requestCookieCompliance=RFC6265@7baf1f5a[INVALID_COOKIES, OPTIONAL_WHITE_SPACE, SPACE_IN_VALUES]
|  |     +> responseCookieCompliance=RFC6265@7baf1f5a[INVALID_COOKIES, OPTIONAL_WHITE_SPACE, SPACE_IN_VALUES]
|  |     +> notifyRemoteAsyncErrors=true
|  |     +> relativeRedirectAllowed=false
|  += ServerConnectorManager@5ad5be4a[keys=0] - STARTED
...
@joakime joakime added the Bug For general bugs on Jetty side label Aug 14, 2024
@joakime
Copy link
Contributor Author

joakime commented Aug 14, 2024

Many of the attributes are also missing from JMX too.

@joakime
Copy link
Contributor Author

joakime commented Aug 14, 2024

The output of JMX MBean Attributes (via jmc)

mbeans-httpconfig

None of the compliance modes seem to be listed.

@joakime joakime moved this to 🏗 In progress in Jetty 12.0.13 - FROZEN Aug 14, 2024
@joakime joakime self-assigned this Aug 14, 2024
@joakime
Copy link
Contributor Author

joakime commented Aug 14, 2024

I'm taking this issue.

joakime added a commit that referenced this issue Aug 16, 2024
…time-attributes

Issue #12163 - Adding missing HttpConfiguration fields to JMX and dump()
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.13 - FROZEN Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant