Fixes #11096 - IllegalAccessException when invoking WebSocket endpoint methods in Jetty 12 #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed module "jetty-home-tester" to "jetty-testers". * Moved JettyHomeTester to module jetty-testers. * Introduced JPMSTester, refactoring common code with JettyHomeTester. * Changed File-based APIs in favor of Path APIs. * Introduced ProcessWrapper to simplify process forking. * Refactored tests to follow refactoring changes. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…t methods in Jetty 12 Changed `JettyWebSocketFrameHandlerFactory` to use an application MethodHandle.Lookup (rather than a server one) when creating listener metadata. This fixes the JPMS problem so that now JPMS applications do not need any additional configuration to invoke endpoints. The (acceptable) downside is that anonymous inner classes (that are not public) cannot be used as listener endpoints. This change affects core and EE10 WebSocket; EE9 and EE8 WebSocket have not been fixed (so they allow anonymous inner classes but are broken in JPMS). Renamed "connectLatch" fields to "openLatch" in test classes. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@sbordet this is failing |
|
@olamy when you can, please look at the failures of this PR... No idea why the artifact could not be found. |
…sitive. This allows Jenkins (which has an empty local repository) to build the artifacts transitively. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
previously approved these changes
Jan 16, 2024
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
lachlan-roberts
previously approved these changes
Jan 24, 2024
sbordet
dismissed stale reviews from lachlan-roberts and olamy
The base branch was changed.
Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
approved these changes
Jan 24, 2024
olamy
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
JettyWebSocketFrameHandlerFactoryto use an application MethodHandle.Lookup (rather than a server one) when creating listener metadata. This fixes the JPMS problem so that now JPMS applications do not need any additional configuration to invoke endpoints. The (acceptable) downside is that anonymous inner classes (that are not public) cannot be used as listener endpoints.This change affects core and EE10 WebSocket; EE9 and EE8 WebSocket have not been fixed (so they allow anonymous inner classes but are broken in JPMS).
Renamed "connectLatch" fields to "openLatch" in test classes.