-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken client tls negotiation #11999
Fix broken client tls negotiation #11999
Conversation
…eption in SslEndPoint.fill() Signed-off-by: Ludovic Orban <lorban@bitronix.be>
… fill() is called with an empty buffer Signed-off-by: Ludovic Orban <lorban@bitronix.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's going to be difficult to know when to use one constant vs the newly introduced one.
Can we make the old constant non-read only?
…0.x/11965-broken-client-tls-negotiation
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…0.x/11965-broken-client-tls-negotiation
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/Content.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
…0.x/11965-broken-client-tls-negotiation
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
When the Jetty client needs to negotiate TLS with the server, it fails to do so and cannot open a connection.
The only indication is the following debug log:
This happens because we mistakenly pass a read-only empty byte buffer to a
fill()
method that tries to append to it, so it fails with an exception instead of returning that zero byte was copied.Fixes #11965