Make sure the delegate callback has been failed before SendCallback's iteration returns #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lback's iteration returns Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #12330
LargeHeaderTest.testLargeHeaderNewConnectionsConcurrent()tests a write failure case, with the given callback being of invocable type BLOCKING. In this case,SendCallback.onFailure()gives the responsibility of failing the delegate callback to an executor, meaning that whenSendCallback.iterate()returns the delegate callback may or may not has been failed.This behavior is racy and may lead to all kinds of problems in the server, like the response data being written before the headers, NPEs, ISEs...