Made scan a new format callable #2062
Conversation
SadiinsoSnowfall
force-pushed
the
callable/scan
branch
from
8b89205 to
14eabbd
Compare
|
I need some help with the documentation on this one |
SadiinsoSnowfall
force-pushed
the
callable/scan
branch
from
b45f973 to
dafef07
Compare
SadiinsoSnowfall
force-pushed
the
callable/scan
branch
from
b9d7223 to
f5db326
Compare
include/eve/concept/generator.hpp
Outdated
| //! @groupheader{Examples} | ||
| //! - `eve::one` | ||
| //! - `eve::one_t` |
There was a problem hiding this comment.
I undrestand where you coming from but this is not a helpful doc.
eve::one is what people should be using. one_t is almost never used.
@jfalcou help me here.
There was a problem hiding this comment.
Yeah, I asked @SadiinsoSnowfall to change it as technically the concept works on type not value.
We can change it back no problem.
There was a problem hiding this comment.
I updated the documentation, let me know
include/eve/concept/substitute.hpp
Outdated
| //! `eve::as_value` on a value of the first type. | ||
| //================================================================================================ | ||
| template<typename S, typename Target> | ||
| concept substitute_for = generator_for<S, Target> || ((arithmetic_value<S> || relaxed_logical_value<S>) && requires(S s) { Target{s}; }); |
There was a problem hiding this comment.
requires(S s) { Target{s}; }
That's constructible. I'm not sure if we want convertible or constructible though.
Why arithmetic || relaxed logical? That is value, no?
There was a problem hiding this comment.
value doesn't include bool and we don't have(/want?) relaxed_value. I guess I could do value<S> || std::same_as<S, bool>
There was a problem hiding this comment.
Should be fixed
No description provided.