Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on the Publish Python distribution to PyPI and TestPyPI Action #38

Open
jfcabana opened this issue Dec 20, 2023 · 5 comments
Open

Comments

@jfcabana
Copy link
Owner

The "Sign the Python Distribution" job is returning the following error:
image

@jfcabana
Copy link
Owner Author

Additionnally, I can see that the current release on Github is 1.5.1

I thought the Action would automatically create a release on github along with publication on pypi, but that does not seem to be the case.

LuisOlivaresJ added a commit that referenced this issue Dec 22, 2023
Related to issue #38. We need to create a new release.
@LuisOlivaresJ
Copy link
Collaborator

Screenshot from 2023-12-27 12-37-59

It worked 💪

@jfcabana
Copy link
Owner Author

Yes! Good job!

@LuisOlivaresJ
Copy link
Collaborator

guthub release error

The workflow is creating a new release. The name of the release is copied from the name of the branch or tag that triggered the workflow.

By my understanding, in order to avoid an error in future pull requests, we need to add a tag (on the branch you want to merge into OMG_master) if we want an automatic release on GitHub. I will try to add a line of code to skipt the GitHub-release job if the pull request does not have a tag.

LuisOlivaresJ added a commit that referenced this issue Jan 19, 2024
LuisOlivaresJ added a commit that referenced this issue Jan 23, 2024
@LuisOlivaresJ
Copy link
Collaborator

The last pull request #43 did not resolve this issue. But I am not sure if made a mistake in the order of the Git commands that I wrote
1.- I committed the new line of code,
2.- Pushed the commit to GitHub,
3.- Added a tag,
4.- Pushed the tag to GitHub
5.- Made the pull-request.

i.e. the commit and the tag where made in different push.

Maybe we have to commit, add a tag, and after that push to GitHub (and make a pull request).

Would you like to try? For example:

1.- create a new branch,
2.- change "pyproject.toml" version = "1.6.3" to version = "1.6.4",
3.- commit the change,
4.- add a tag (for example v1.6.4),
5.- push
6.- Make a pull request to OMG_master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants