Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual ROI selection for calibration. #53

Closed
LuisOlivaresJ opened this issue Jun 26, 2024 · 2 comments
Closed

Manual ROI selection for calibration. #53

LuisOlivaresJ opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@LuisOlivaresJ
Copy link
Collaborator

Hello there,

In calibration module...

Once the image with the irradiated films is shown and I draw a manual ROI, a new one is created every time a click is released. That behaviour does no allow to change the RectangleSelector size, or move it to use the same RectangleSelector for another film.

This is not an issue, so I labeled it as a possible enhancement. I think that it could be "user-friendly" to perform a ROI creation when a key is pressed instead when a click is released.

Let me know what do you think. I can work in that.
Cheers,

@LuisOlivaresJ LuisOlivaresJ added the enhancement New feature or request label Jun 26, 2024
@LuisOlivaresJ LuisOlivaresJ changed the title Manual ROI selection for calibration is a little unconfortable. Manual ROI selection for calibration. Jun 26, 2024
@jfcabana
Copy link
Owner

I know exactly what you mean, and it has always bothered me also :D I just never took the time to change it. If you are willing to work on it, please go ahead :)

@LuisOlivaresJ
Copy link
Collaborator Author

Working on it in branch manual_roi_automatic

LuisOlivaresJ added a commit that referenced this issue Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants