Fix codecov #211
Merged
Fix codecov #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnetCarpenter
force-pushed
the
fix_codecov
branch
from
5a9a12b to
3d9a70b
Compare
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage ? 75.59%
=========================================
Files ? 9
Lines ? 508
Branches ? 115
=========================================
Hits ? 384
Misses ? 45
Partials ? 79Continue to review full report at Codecov.
|
jfhbrook
approved these changes
Dec 16, 2017
|
Works for me! I added you as a collaborator, so you should be able to make changes if I die in a ditch. :) I'll try to be around for review and advice though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the node version of codecov and uses the bash version instead.
So the longer any nonsense codecov when doing local
npm testalso I put in an auto job flag fortap, so if you got multiple processors, it should speed up tests.Hurry up and merge this in :) Then I can rebase #209 to master and we see if PR's adds or lower the coverage. But we need at least one coverage report in master before it works.
oh, and I also changed from lcov to clover reports - not sure what the difference is but I found an example with clover and codecov...