Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publicresults timer behavior on page refresh #866

Closed
jflamy opened this issue Mar 10, 2024 · 3 comments
Closed

publicresults timer behavior on page refresh #866

jflamy opened this issue Mar 10, 2024 · 3 comments

Comments

@jflamy
Copy link
Owner

jflamy commented Mar 10, 2024

Timer should not restart - investigate why the time is not recomputed.
Perhaps use the restore-on-refresh feature from Vaadin.

@jflamy
Copy link
Owner Author

jflamy commented May 4, 2024

fixed using absolute time.

@jflamy jflamy closed this as completed May 4, 2024
@scottgonzalez
Copy link
Collaborator

Using absolute time causes issues when the local server does not have its clock set correctly. Rather than using the start timestamp supplied by server, it would be more resilient to get a local timestamp when the event occurs. While this can cause a slight drift due to network latency, the drift would be the same that would have existed prior to this change.

@scottgonzalez
Copy link
Collaborator

The change requested above is tracked in gh-930.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants