Jamr rebase #8
Open
Jamr rebase #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dout Conflicts: src/AMRParser.scala src/Aligner.scala
…ent basic (non named) chacheing of State2 weights Conflicts: src/AlignSpans2.scala src/Aligner.scala
…lts. Additional concepts.
Conflicts: src/AMRParser.scala
|
Oh, I'm sorry, I was only looking at the last commit "Added --input and --output options...". Lot's more changes here than I thought... |
| var previousStage2: Map[String, GraphDecoder.Decoder] = Map() | ||
|
|
||
| // an optional callback that lets us get direct access to decoderResultGraph when parsing | ||
| var resultHandler: Option[Graph => Unit] = None |
There was a problem hiding this comment.
I don't see this ever being set to anything other than None.
Also, adding side-effecting callbacks makes the code harder to grok/change/debug/test. Is there a way to extract a method for the part of the code that produces decoderResultGraph instead?
|
Thanks Sam! Yeah I'll get to it soon, I just had some other stuff to take care of first. |
|
Jeff, any idea when you may take a look at this? I have more work I'd like to do but I'm holding off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes to allow JAMR to integrate with and run in a server environment.