Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes found in the result cache #150

Merged
merged 16 commits into from
Feb 2, 2023
Merged

Apply fixes found in the result cache #150

merged 16 commits into from
Feb 2, 2023

Conversation

jfmengels
Copy link
Owner

This change tries to apply fixes from errors found in the result cache. That means that even if we reuse the cache for a given module, we will try to find fixes. This is annoying for performance, but (so far at least) necessary because when the cache comes directly from the file system, we have never gone through the errors.

Basically, this PR solves the following issue:

$ elm-review --fix-all
# Found 10 fixable errors
<exit before accepting the fix>
$ elm-review --fix-all
I found no issues.

While developing this change, I created additional bugs because I forgot to update the ContentHash in ProjectModule (which happen to never cause problems, I think, before this change). To prevent this from happening again, I made ProjectModule opaque.

@jfmengels jfmengels merged commit e51537c into master Feb 2, 2023
@jfmengels jfmengels deleted the fixes-from-cache branch February 2, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant