Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fs-extra #120

Open
jfmengels opened this issue Apr 21, 2023 · 1 comment · May be fixed by #147
Open

Replace fs-extra #120

jfmengels opened this issue Apr 21, 2023 · 1 comment · May be fixed by #147
Labels
help wanted We could use your help

Comments

@jfmengels
Copy link
Owner

In #119 we replaced most usages of fs-extra.
We kept it because of the copy capabilities that it has that are not in fs or graceful-fs.

(Note: it's fine to keep it in new-package/maintenance/update-examples-from-preview.js, that's a separate generated project for packages)
@jfmengels jfmengels added the help wanted We could use your help label Apr 21, 2023
@lydell
Copy link
Contributor

lydell commented Mar 17, 2024

According to https://nodejs.org/api/fs.html#fscopyfilesyncsrc-dest-mode, fs.copyFileSync has existed since Node.js 8.5.0, so after a quick search it looks like all that needs to be done is to change fsExtra.copyFileSync into fs.copyFileSync and then remove fs-extra.

@jfmengels jfmengels linked a pull request Mar 17, 2024 that will close this issue
Open
@lishaduck lishaduck mentioned this issue Jun 24, 2024
Open
21 tasks
@lishaduck lishaduck mentioned this issue Jul 19, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We could use your help
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove fs-extra jfmengels/node-elm-review
2 participants
@lydell @jfmengels