Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fs-extra by a custom fs wrapper #119

Merged
merged 27 commits into from
Apr 21, 2023
Merged

Replace fs-extra by a custom fs wrapper #119

merged 27 commits into from
Apr 21, 2023

Conversation

jfmengels
Copy link
Owner

@jfmengels jfmengels commented Apr 21, 2023 •
edited
Loading

This remove the need to util.promisify plenty of functions at the top of each file, and to create a simpler API for FS operations.

We keep fs-extra because of its copy capabilities, but that would be nice to replace.

@jfmengels
Add graceful-fs as a dependency
4d068c6
@jfmengels
Add custom file to read JSON files
2119979
@jfmengels
Use custom json read file function
2531ac0
@jfmengels
Delay computing cacheLocation
429aa46
@jfmengels
Don't pass null everywhere
a027c44
@jfmengels
Use custom json read file function
b91edb0
@jfmengels
Import as FS
a726b96
@jfmengels
Use custom json read file function
7d42962
@jfmengels
Define promisified writeFile once
98a1116
@jfmengels
Hardcode JSON.stringify result
e6276b9
@jfmengels
Add FS.writeJson
8b6aabf
@jfmengels
Rename json-fs to fs-wrapper
259eba6
@jfmengels
Define promisified ensureDir once
3c9a918
@jfmengels
Use FS.writeJson
96e0a18
@jfmengels
Define ensureDir as mkdirp (fixes crash)
a54840b
@jfmengels
Define promisified fs.mkdir once
db47b0d
@jfmengels
Use FS.writeJson
5ed8b3c
@jfmengels
Use FS.readJsonFile
c3a02c8
@jfmengels
Replace fs-extra by fs in lib code
ddf84e2
@jfmengels
Add TODO
d60c6ce
@jfmengels
Define promisified fs.readdir in fs-wrapper
a5966c4
@jfmengels
Use fs-wrapper functions
5cd4982
@jfmengels
Add rimraf as a dependency
a21b7d9
@jfmengels
Replace fs-extra's remove by rimraf
83d9e66
@jfmengels
Add FS.mkdirpSync
80c592b
@jfmengels
Add FS.readJsonFileSync
c286e6c
@jfmengels
Use copySync from fsExtra
9dd9b54
@jfmengels jfmengels merged commit 9dd9b54 into master Apr 21, 2023
@jfmengels jfmengels mentioned this pull request Apr 21, 2023
Closed
@jfmengels jfmengels deleted the fs branch April 22, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfmengels