-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types to app-wrapper.js
#155
Conversation
app-wrapper.js
lib/app-wrapper.js
Outdated
/** | ||
* @typedef { import('./types/options').Options } Options | ||
* @typedef { import('./types/options').ReviewOptions } ReviewOptions | ||
* @typedef { import('./types/app').App } App | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once ts 5.5 is stable (which should be soon), we can switch to the import syntax instead here:
/** | |
* @typedef { import('./types/options').Options } Options | |
* @typedef { import('./types/options').ReviewOptions } ReviewOptions | |
* @typedef { import('./types/app').App } App | |
*/ | |
/** | |
* @import {Options} from './types/options'; | |
* @import {ReviewOptions} from './types/options'; | |
* @import {App} from './types/app'; | |
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looking forward to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
soon
Today!
I'm currently cleaning up this branch locally, I should have something up today or tomorrow (certainly tomorrow in Europe. How's the future? 😉).
Oh, I see. This is blocked on #126. I'll try to see if I fix it sometime. |
Ok, the failures from #126 were a bit intimidating, so I figure I'll just port them over here and just coauthor them. |
Co-authored-by: Henrique Buss <henriquebusss@gmail.com>
TS 5.5 might fix this, but we've still got time.
I plan on relanding this as separate PRs later this week. |
Sounds good, take your time @lishaduck and thank you for looking into this! |
Flags is something that looks very much like |
Yikes! I'm up to 1 |
I'm unsure as what type
flags
is supposed to be, beyond that it's notFlags
.I'm pretty sure VSCode was wrong that it's
Options
.Relates to: #125