chore: enable noImplicitAny on dependency-provider.js
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
99% unblocked. Just need a new npm release of elm-solve-deps-wasm. |
|
Yahooooooo!!!!! |
It wasn't worthy of a pr, so I'm slipping these in here.
lishaduck
force-pushed
the
dependency-provider-no-implicit-any
branch
from
919b2a3 to
9c72d2b
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Nice work! |
lydell
added a commit
to rtfeldman/node-test-runner
that referenced
this pull request
Feb 14, 2025
This is commit switches to the same version constraint of elm-solve-deps-wasm as elm-review uses these days. (Since 2.13.0, via jfmengels/node-elm-review#195.) The benefit of this commit is that if you install the latest version of both elm-test and elm-review, you only get one copy of elm-solve-deps-wasm in node_modules/ instead of two, saving about 288 KB. Closes #636. This commit does the same thing as that PR, but without updating the package-lock.json version. That will be done some other time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to be merged, except for the part where I add a github dependency.
Blocked by: mpizenberg/elm-solve-deps-wasm#3.
Depends on: #191.
Relates to: #125.
Here's the diff, as GH doesn't play well with stacks from forks: lishaduck/node-elm-review@result-cache-json-no-implict-any...dependency-provider-no-implict-any